Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italic text does not work in markdown #701

Closed
timholl opened this issue Nov 1, 2019 · 5 comments · Fixed by #702
Closed

Italic text does not work in markdown #701

timholl opened this issue Nov 1, 2019 · 5 comments · Fixed by #702

Comments

@timholl
Copy link
Contributor

timholl commented Nov 1, 2019

Similar to #678 , just for italic text.

before1
displayed as
before2
but should
after

@timholl
Copy link
Contributor Author

timholl commented Nov 1, 2019

@raimund-schluessler
Copy link
Member

@timholl
Copy link
Contributor Author

timholl commented Nov 1, 2019

I also tested other common Markdown stuff, that works.

Conceptual one could make a clean-start inside the markdown container with

#markdown {
   all: initial;
   * {
      all: unset;
   }
}

to reset every style to its default, since that rendered markdown will neither make use of nextcloud-specific styles nor should apply to that (like in this case) anyway.

But that would be kind of brute-force.

@raimund-schluessler
Copy link
Member

I also tested other common Markdown stuff, that works.

Conceptual one could make a clean-start inside the markdown container with

#markdown {
   all: initial;
   * {
      all: unset;
   }
}

to reset every style to its default, since that rendered markdown will neither make use of nextcloud-specific styles nor should apply to that (like in this case) anyway.

But that would be kind of brute-force.

Hm, I think this would be to much. E.g. the font-color should align with the general nextcloud style and we would need to set it again then.

@timholl
Copy link
Contributor Author

timholl commented Nov 1, 2019

. E.g. the font-color should align with the general nextcloud style and we would need to set it again then.

Yes, but it would make us immune against upstream style changes in core instead of manually reverting them afterwards. ^^

Just an idea, though. Will implement a prototype when the next issue occurs at that point :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants