Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make stylelint SCSS more strict #1144

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Make stylelint SCSS more strict #1144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35d9954
Add stricter SCSS stylelint rules
raimund-schluessler Jul 26, 2020
9f73c5a
Fix SCSS style issues
raimund-schluessler Jul 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion .stylelintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,13 @@
"selector-type-case": null,
"selector-list-comma-newline-after": null,
"no-descending-specificity": null,
"string-quotes": "single"
"string-quotes": "single",
"selector-combinator-space-before": "always",
"selector-combinator-space-after": "always",
"declaration-block-no-duplicate-properties": true,
"no-extra-semicolons": true,
"declaration-colon-space-after": "always",
"declaration-colon-space-before": "never"
},
"plugins": [
"stylelint-scss"
Expand Down
11 changes: 5 additions & 6 deletions css/src/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,6 @@ $blue_due: #4271a6; // due dates and low importance

.colorpicker {
display: block;
height: 30px;
height: auto;
padding-bottom: 3px;
padding-top: 3px;
Expand Down Expand Up @@ -478,7 +477,7 @@ $blue_due: #4271a6; // due dates and low importance
}

&.add-task {
border-top: 1px solid var(--color-border);
border-top: 1px solid var(--color-border);

input {
border-top-left-radius: 0;
Expand Down Expand Up @@ -648,7 +647,7 @@ $blue_due: #4271a6; // due dates and low importance
display: flex;
margin-left: auto;

&>div:not(.action-item) {
& > div:not(.action-item) {
height: 44px;
padding: 14px 7px;
display: flex;
Expand Down Expand Up @@ -680,7 +679,7 @@ $blue_due: #4271a6; // due dates and low importance
}
}

&>div.task-status-container {
& > div.task-status-container {
padding: 14px 0;

.status-display {
Expand Down Expand Up @@ -842,7 +841,7 @@ $blue_due: #4271a6; // due dates and low importance
display: flex;
justify-content: space-between;

>span {
> span {
padding: 14px;

&.info {
Expand Down Expand Up @@ -1270,7 +1269,7 @@ $blue_due: #4271a6; // due dates and low importance
&::before {
margin-left: 0;
}
>span {
> span {
font-weight: bold;
margin-left: 10px;
}
Expand Down