Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create task from Talk message #1649

Merged
merged 1 commit into from Jul 13, 2021
Merged

Conversation

jakobroehrl
Copy link
Contributor

@jakobroehrl jakobroehrl commented Jun 23, 2021

Signed-off-by: Jakob Röhrl jakob.roehrl@web.de

Todo


Screenshots:
Screenshot 2021-06-24 at 11-02-54 Talk updates ✅ - Talk - Nextcloud

image


references:
nextcloud/deck#2795

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #1649 (ba934f3) into master (4873158) will decrease coverage by 0.70%.
The diff coverage is 6.41%.

❗ Current head ba934f3 differs from pull request most recent head 033d851. Consider uploading reports for the commit 033d851 to get more accurate results

@@             Coverage Diff              @@
##             master    #1649      +/-   ##
============================================
- Coverage     31.89%   31.19%   -0.71%     
- Complexity       35       41       +6     
============================================
  Files            58       62       +4     
  Lines          2856     2933      +77     
  Branches        540      546       +6     
============================================
+ Hits            911      915       +4     
- Misses         1945     2018      +73     

webpack.js Outdated Show resolved Hide resolved
@raimund-schluessler

This comment has been minimized.

@jakobroehrl

This comment has been minimized.

@jakobroehrl

This comment has been minimized.

@raimund-schluessler

This comment has been minimized.

@jakobroehrl

This comment has been minimized.

@raimund-schluessler

This comment has been minimized.

@raimund-schluessler

This comment has been minimized.

@raimund-schluessler
Copy link
Member

  • Select the default task list instead of the first one: I always get the personal calendar here:
    defaultCalendarId: {
    get() {
    const cal = this.$store.getters.getDefaultCalendar
    return cal ? cal.id : ''
    },

    Why?

The default calendar is not loaded here. Normally it comes from the initialState service, see https://github.com/nextcloud/tasks/blob/master/lib/Controller/PageController.php#L62
But here in Talk, this does not work, since the initial state is never loaded. So we need a separate endpoint in PHP to get only the default calendar and then query it in Javascript via axios.

@jakobroehrl

This comment has been minimized.

@raimund-schluessler

This comment has been minimized.

@jakobroehrl

This comment has been minimized.

@raimund-schluessler

This comment has been minimized.

@raimund-schluessler raimund-schluessler force-pushed the enh/createTaskFromTalkMsg branch 3 times, most recently from a35d107 to 3bc5cfa Compare July 2, 2021 21:05
Signed-off-by: Jakob Röhrl <jakob.roehrl@web.de>
@raimund-schluessler
Copy link
Member

@jakobroehrl Please have a look. I think it works ok, but needs some style fixes.

@jakobroehrl
Copy link
Contributor Author

@jakobroehrl Please have a look. I think it works ok, but needs some style fixes.

It's working great! The looks a bit weired, but I didn't figure it out how to solve.
image

@raimund-schluessler
Copy link
Member

I will merge this now as it is, since it works as it should. Style fixes will come with #1682 later.

@raimund-schluessler raimund-schluessler merged commit b2584f7 into master Jul 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the enh/createTaskFromTalkMsg branch July 13, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants