Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show dashboard actions for readonly tasks #2017

Merged
merged 1 commit into from Jul 27, 2022

Conversation

raimund-schluessler
Copy link
Member

This PR prevents showing a non-functional mark-as-complete action for read only tasks in the Dashboard.

Requires #1985 and nextcloud-libraries/nextcloud-vue#2718.

Before:
Screenshot 2022-06-01 at 22-46-13 Dashboard - Nextcloud

After:
Screenshot 2022-06-01 at 22-54-37 Dashboard - Nextcloud

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@2bb140e). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 27c544f differs from pull request most recent head 5a22413. Consider uploading reports for the commit 5a22413 to get more accurate results

@@            Coverage Diff            @@
##             master    #2017   +/-   ##
=========================================
  Coverage          ?   29.17%           
  Complexity        ?       41           
=========================================
  Files             ?       69           
  Lines             ?     2992           
  Branches          ?      667           
=========================================
  Hits              ?      873           
  Misses            ?     2119           
  Partials          ?        0           

@raimund-schluessler raimund-schluessler force-pushed the feature/noid/custom-dashboard-actions branch from 27c544f to bcad466 Compare June 1, 2022 20:58
@raimund-schluessler raimund-schluessler marked this pull request as draft June 1, 2022 21:00
@raimund-schluessler raimund-schluessler added this to the 0.14.5 milestone Jun 1, 2022
@raimund-schluessler raimund-schluessler added enhancement dependencies Pull requests that update a dependency file labels Jun 1, 2022
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler force-pushed the feature/noid/custom-dashboard-actions branch from bcad466 to 5a22413 Compare July 27, 2022 20:34
@raimund-schluessler raimund-schluessler marked this pull request as ready for review July 27, 2022 20:37
@raimund-schluessler raimund-schluessler merged commit f4bd7b3 into master Jul 27, 2022
@delete-merged-branch delete-merged-branch bot deleted the feature/noid/custom-dashboard-actions branch July 27, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant