Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust server versions to be tested #2073

Merged
merged 4 commits into from Oct 19, 2022

Conversation

raimund-schluessler
Copy link
Member

This adjusts the nextcloud server and php versions to be tested:

@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Merging #2073 (aacb23c) into master (3857ef6) will decrease coverage by 0.36%.
The diff coverage is 75.00%.

❗ Current head aacb23c differs from pull request most recent head a539aef. Consider uploading reports for the commit a539aef to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2073      +/-   ##
============================================
- Coverage     29.74%   29.38%   -0.37%     
+ Complexity       41       39       -2     
============================================
  Files            70       69       -1     
  Lines          2851     2801      -50     
  Branches        655      655              
============================================
- Hits            848      823      -25     
+ Misses         2003     1978      -25     

@raimund-schluessler raimund-schluessler added this to the 0.14.5 milestone Aug 15, 2022
@raimund-schluessler
Copy link
Member Author

@ChristophWurst I am a bit stuck here, since I can't get the composer.json and composer.lock.json to work with PHP 7.3 to 8.1. It always complains about Your lock file does not contain a compatible set of packages. Please run composer update., but that fixes it only for the PHP version I run composer update for. Any hint would be very appreciated.

@ChristophWurst
Copy link
Member

Looks like your symfony/* packages are too new. Try overwriting the php version in composer.json's config like https://github.com/nextcloud/calendar/blob/main/composer.json#L4, then run composer update. This will hopefully give you a set of packages that work from 7.4 to 8.1. IIRC we had rare cases where this was impossible. Then we installed packages dynamically on CI or used the --ignore-platform-req=php flag of composer i.

@raimund-schluessler raimund-schluessler modified the milestones: 0.14.5, 0.14.6 Oct 18, 2022
@raimund-schluessler raimund-schluessler force-pushed the fix/noid/server-versions-tested branch 2 times, most recently from 11e5e29 to 6e57ce8 Compare October 18, 2022 18:49
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler
Copy link
Member Author

Looks like your symfony/* packages are too new. Try overwriting the php version in composer.json's config like https://github.com/nextcloud/calendar/blob/main/composer.json#L4, then run composer update. This will hopefully give you a set of packages that work from 7.4 to 8.1. IIRC we had rare cases where this was impossible. Then we installed packages dynamically on CI or used the --ignore-platform-req=php flag of composer i.

Thanks a lot, that was it.

@raimund-schluessler raimund-schluessler merged commit e3ef9c8 into master Oct 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/noid/server-versions-tested branch October 19, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants