Explicitly set appendToBody to false for NcSelect #2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2197 +/- ##
=============================================
+ Coverage 28.65% 68.33% +39.68%
Complexity 39 39
=============================================
Files 69 9 -60
Lines 3033 120 -2913
Branches 733 0 -733
=============================================
- Hits 869 82 -787
+ Misses 2164 38 -2126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not really required here, since
falseis the default, but fixes an issue with the vue3 version. So why not here already. Follow-up to #2193.