Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show notes equally in editing and preview mode #2209

Merged
merged 1 commit into from Feb 28, 2023

Conversation

raimund-schluessler
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #2209 (fbef099) into master (7bcd5f2) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2209   +/-   ##
=========================================
  Coverage     28.65%   28.65%           
  Complexity       39       39           
=========================================
  Files            69       69           
  Lines          3033     3033           
  Branches        733      733           
=========================================
  Hits            869      869           
  Misses         2164     2164           

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@raimund-schluessler raimund-schluessler merged commit b83aba9 into master Feb 28, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/noid/notes-style branch February 28, 2023 20:12
@oktayacikalin
Copy link

oktayacikalin commented May 17, 2023

I just got the update in my NC instance and it looks mostly great. Linefeeds are still inconsistent. For example "\n\n" in edit mode is trimmed down to "\n".

@raimund-schluessler
Copy link
Member Author

I just got the update in my NC instance and it looks mostly great. Linefeeds are still inconsistent. For example "\n\n" in edit mode is trimmed down to "\n".

Yes, as far as I can tell, that is a limitation of markdown itself. See the statement of the creator of the mardown plugin we use:
markdown-it/markdown-it#211 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants