fix: don't set percent to 0 for NEEDS-ACTION #2365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
force-pushed
the
fix/2335/percent
branch
from
48541bf
to
25fa826
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2365 +/- ##
==========================================
+ Coverage 26.51% 26.53% +0.02%
==========================================
Files 63 63
Lines 3070 3071 +1
Branches 683 684 +1
==========================================
+ Hits 814 815 +1
Misses 2256 2256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the
percent-completevalue is not set to zero anymore, when the status is removed or set toNEEDS-ACTION. However, when the task is completed, and the status is set toNEEDS-ACTION, thepercent-completevalue is set to99.Closes #2335.