New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load task from server if not found locally #608
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #608 +/- ##
=========================================
- Coverage 5.82% 5.66% -0.17%
=========================================
Files 45 45
Lines 1939 1996 +57
Branches 343 351 +8
=========================================
Hits 113 113
- Misses 1679 1730 +51
- Partials 147 153 +6 |
skjnldsv
reviewed
Sep 16, 2019
raimund-schluessler
force-pushed
the
fix-606
branch
from
September 16, 2019 19:43
1da6b9d
to
ed0d87a
Compare
This should be good to go now. |
skjnldsv
reviewed
Sep 19, 2019
skjnldsv
reviewed
Sep 19, 2019
skjnldsv
requested changes
Sep 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments :)
Fixed it. Looks much better now with async/await. |
skjnldsv
reviewed
Sep 20, 2019
skjnldsv
reviewed
Sep 20, 2019
skjnldsv
reviewed
Sep 20, 2019
skjnldsv
reviewed
Sep 20, 2019
skjnldsv
reviewed
Sep 20, 2019
skjnldsv
reviewed
Sep 20, 2019
skjnldsv
reviewed
Sep 20, 2019
skjnldsv
reviewed
Sep 20, 2019
skjnldsv
reviewed
Sep 20, 2019
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org> Co-Authored-By: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
force-pushed
the
fix-606
branch
from
September 20, 2019 07:57
af7a54e
to
441d741
Compare
Rebased. |
skjnldsv
reviewed
Sep 20, 2019
skjnldsv
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #606. When a requested task is not found locally, we try to load it from the server.
Todo:
uri
@georgehrke @skjnldsv ?What I don't like so much is that I have to watch the calendar (https://github.com/nextcloud/tasks/pull/608/files#diff-128fe9ee0ed5aeabe3c64281c67285c0R584), but it was the easiest way to load a task only after the calendars are loaded.