Increase clickable area of active elements #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
raimund-schluessler
changed the title
Codecov Report
@@ Coverage Diff @@
## master #735 +/- ##
=======================================
Coverage 26.48% 26.48%
=======================================
Files 44 44
Lines 2122 2122
Branches 393 393
=======================================
Hits 562 562
Misses 1437 1437
Partials 123 123 |
|
Very cool @raimund-schluessler! :) I’d say another big thing which would really improve the look of the app is thinking about ways to remove all the border lines (for that we mainly have to think about how to present the info presented as icons on the right). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the clickable area of active elements to be 44px x 44px following the Nextcloud standard and closing #392. @skjnldsv @jancborchardt
The sortorder dropdown in the top right I will adjust in a follow-up PR.
Before:
After:
