Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use eslint-config-nextcloud #843

Merged
merged 1 commit into from Jan 30, 2020
Merged

Use eslint-config-nextcloud #843

merged 1 commit into from Jan 30, 2020

Conversation

raimund-schluessler
Copy link
Member

With this PR the Tasks code now follows the eslint-config-nextcloud rules. Closes #837

@skjnldsv This one is for you 😉

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #843 into master will not change coverage.
The diff coverage is 36%.

@@           Coverage Diff           @@
##           master     #843   +/-   ##
=======================================
  Coverage   31.94%   31.94%           
=======================================
  Files          23       23           
  Lines        1252     1252           
  Branches      223      223           
=======================================
  Hits          400      400           
  Misses        728      728           
  Partials      124      124

.eslintrc.js Show resolved Hide resolved
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
A few comments, but looks great!

Btw, with the new github actions, you can get linting comments in your pr directly 🗡️
I can provide a pr

@skjnldsv
Copy link
Member

Btw, with the new github actions, you can get linting comments in your pr directly
I can provide a pr

#844

@skjnldsv skjnldsv merged commit 3ae9306 into master Jan 30, 2020
@skjnldsv skjnldsv deleted the eslint-nextcloud branch January 30, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use nextcloud eslint config
2 participants