Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also show due time in task body on large screens #992

Merged
merged 1 commit into from Apr 30, 2020

Conversation

raimund-schluessler
Copy link
Member

On large screens we also show the due time in the task body.

duetime

Closes #914.

@GambaJo @zeroepix Please have a look.

Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
@codecov
Copy link

codecov bot commented Apr 29, 2020

Codecov Report

Merging #992 into master will increase coverage by 0.15%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #992      +/-   ##
==========================================
+ Coverage   24.91%   25.07%   +0.15%     
==========================================
  Files          48       48              
  Lines        2476     2481       +5     
  Branches      470      473       +3     
==========================================
+ Hits          617      622       +5     
  Misses       1719     1719              
  Partials      140      140              

@zeroepix
Copy link

Looks good. I would certainly appreciate that for the days that I have tighter schedules to follow.

Does it make it extra crowded in the week view? That's the one that needs extra protection from too much info.

@raimund-schluessler
Copy link
Member Author

Does it make it extra crowded in the week view? That's the one that needs extra protection from too much info.

I don't think it is a problem in the week view:
duetime_week

@zeroepix
Copy link

Are you saying my tasks are too long? :)

image

@raimund-schluessler
Copy link
Member Author

Are you saying my tasks are too long? :)

No 😄 This is a testing instance with only test names.
But even with longer names, I think there is enough space. And if a bit of the task name is cutoff, I guess you should still be able to recognize which task it is from the rest of the name 😉

@raimund-schluessler raimund-schluessler merged commit a1cf750 into master Apr 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/914/duedate branch April 30, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Show whole due (date and time) in the list
2 participants