Merge pull request #4297 from nextcloud/bugfix/noid/sync-after-push-r…

…econnect
nextcloud · Jun 21, 2023 · a6b5832 · a6b5832
2 parents a673891 + 72dfc69
commit a6b5832
Show file tree

Hide file tree

Showing 14 changed files with 38 additions and 33 deletions.
diff --git a/cypress/e2e/sync.spec.js b/cypress/e2e/sync.spec.js
@@ -66,26 +66,26 @@ describe('Sync', () => {
 
 	it('recovers from a lost connection', () => {
 		let count = 0
-		cy.intercept({ method: 'POST', url: '**/apps/text/session/push' }, (req) => {
-			if (count < 5) {
-				count++
+		cy.intercept({ method: 'POST', url: '**/apps/text/session/*' }, (req) => {
+			if (count < 4) {
 				req.destroy()
 				req.alias = 'dead'
+			} else {
+				req.alias = 'alive'
 			}
-		}).as('push')
-		cy.intercept({ method: 'POST', url: '**/apps/text/session/sync' }, (req) => {
-			if (count < 5) {
-				count++
-				req.destroy()
-				req.alias = 'deadSync'
-			}
-		})
-		cy.get('#editor-container .document-status')
-			.should('contain', 'File could not be loaded', { timeout: 10000 })
-		cy.get('#editor-container .document-status', { timeout: 30000 })
-			.should('not.contain', 'File could not be loaded')
+		}).as('sessionRequests')
+		cy.wait('@dead', { timeout: 30000 })
+		cy.get('#editor-container .document-status', { timeout: 10000 })
+			.should('contain', 'File could not be loaded')
+			.then(() => {
+				count = 4
+			})
+		cy.wait('@alive', { timeout: 30000 })
 		cy.intercept({ method: 'POST', url: '**/apps/text/session/sync' })
 			.as('syncAfterRecovery')
+		cy.wait('@syncAfterRecovery', { timeout: 30000 })
+		cy.get('#editor-container .document-status', { timeout: 30000 })
+			.should('not.contain', 'File could not be loaded')
 		cy.getContent().type('* more content added after the lost connection{enter}')
 		cy.wait('@syncAfterRecovery')
 		cy.closeFile()

diff --git a/js/editor.js b/js/editor.js
diff --git a/js/editor.js.map b/js/editor.js.map
diff --git a/js/text-editors.js b/js/text-editors.js
diff --git a/js/text-editors.js.map b/js/text-editors.js.map
diff --git a/js/text-files.js b/js/text-files.js
diff --git a/js/text-files.js.map b/js/text-files.js.map
diff --git a/js/text-public.js b/js/text-public.js
diff --git a/js/text-public.js.map b/js/text-public.js.map
diff --git a/js/text-text.js b/js/text-text.js
diff --git a/js/text-text.js.map b/js/text-text.js.map
diff --git a/js/text-viewer.js b/js/text-viewer.js
diff --git a/js/text-viewer.js.map b/js/text-viewer.js.map
diff --git a/src/services/SyncService.js b/src/services/SyncService.js
@@ -161,6 +161,11 @@ class SyncService {
 		return this.connection.push(data)
 			.then((response) => {
 				this.sending = false
+				this.emit('sync', {
+					steps: [],
+					document: this.connection.document,
+					version: this.version,
+				})
 			}).catch(({ response, code }) => {
 				logger.error('failed to apply steps due to collission, retrying')
 				this.sending = false