Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too much vertical spacing around horizontal line #1889

Closed
whisperdancer opened this issue Oct 7, 2021 · 9 comments · Fixed by #3270
Closed

Too much vertical spacing around horizontal line #1889

whisperdancer opened this issue Oct 7, 2021 · 9 comments · Fixed by #3270
Labels
1. to develop bug Something isn't working design Experience, interaction, interface, … good first issue Good for newcomers

Comments

@whisperdancer
Copy link

whisperdancer commented Oct 7, 2021

After update to V 22.2.0 I noticed extra lines being added to the Readme.md files. This happens after adding a line. Here’s how to duplicate:

In web files app, open a folder
Click on upper part to create a Readme.md file
Type Line #1, then type 3 dashes — and press Enter key to create a hard line
Notice it adds the hard line, but inserts 2 lines above and 2 lines below the newly added hard line.

Before update to 22, the text above and below the hard line would hug it tightly without adding additional lines above and below the hard line

To view full report with screenshots, see here https://help.nextcloud.com/t/extra-lines-inserted-after-adding-hard-line-after-update-to-nc-22/124692

@juliushaertl juliushaertl added 0. Needs triage bug Something isn't working design Experience, interaction, interface, … labels Jan 12, 2022
@juliushaertl
Copy link
Member

This was introduced in #1487

@jancborchardt 3em indeed looks quite large looking at the forum screenshots, should we maybe narrow that down a bit again?

@whisperdancer
Copy link
Author

whisperdancer commented Jan 13, 2022

Yes, please revert back to how it was before the increase to 3em. It looked great before the increase.

@whisperdancer

This comment has been minimized.

@juliushaertl

This comment has been minimized.

@whisperdancer

This comment has been minimized.

@juliushaertl
Copy link
Member

You might need to use margin: 1em 0 !important, but lets stick to the actual topic in here. For further customizing questions, please head over to the forums 😉

@jancborchardt
Copy link
Member

This was intended to automatically insert enough whitespace around the line, but maybe it’s indeed too much. We could go for something inbetween, 2em or 2.5 em?

@whisperdancer
Copy link
Author

I'm currently using 1em per custom CSS and it looks great.

@max-nextcloud max-nextcloud changed the title Extra lines inserted after adding hard line after update to NC 22 Too much vertical spacing around horizontal line Oct 18, 2022
max-nextcloud added a commit that referenced this issue Oct 18, 2022
fixes #1889.

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud
Copy link
Collaborator

Going with 2em for now. This is a separator - so it makes sense to actually separate the content a bit.

backportbot-nextcloud bot pushed a commit that referenced this issue Oct 19, 2022
fixes #1889.

Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
max-nextcloud added a commit that referenced this issue Oct 19, 2022
fixes #1889.

Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop bug Something isn't working design Experience, interaction, interface, … good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants