Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buttons to change list indentation level #2438

Open
flueders opened this issue May 23, 2022 · 12 comments
Open

Add buttons to change list indentation level #2438

flueders opened this issue May 23, 2022 · 12 comments
Labels
enhancement New feature or request

Comments

@flueders
Copy link

Is your feature request related to a problem? Please describe.
When I tried to create (un-)ordered lists with more than one level, I couldn't find an intuitive way to do this (since there is also no way to change to code view). My first workaround was to edit the file in an external editor, but this is no good solution, I think.

After some research, I discovered the "official" way of indenting list entries: pressing the tab key. However, there was this issue which added additional problems.

And, by the way, I still don't know how to decrease the list indention level using the keyboard.

Describe the solution you'd like
I would like to have a button to easily change a list entry's level. This could also be a drop-down underneath the list buttons.

Describe alternatives you've considered
As written before: using external editors or the tab key. There is also the markdown editor app, which handles this problem by offering a code view.

Additional context
Maybe related to #234

@flueders flueders added the enhancement New feature or request label May 23, 2022
@juliushaertl
Copy link
Member

I think especially on mobile such buttons would generally make sense, where I also run into this from time to time. Would be interesting to see how other editors and mobile apps handle this, as adding just more icons to the menubar is nothing we can do any longer, as is is already really crowded now that we added more general formatting options.

One option might be a contextual toolbar that only displays relevant actions based on the content type, maybe at the bottom of the screen? Or a floating menu before or after the content https://tiptap.dev/api/extensions/floating-menu

cc @nimishavijay @jancborchardt @max-nextcloud @vinicius73

@nimishavijay
Copy link
Member

One option might be a contextual toolbar that only displays relevant actions based on the content type

This sounds good! I like the idea of having formatting options in the bottom of the screen since the top is getting crowded now.

Or a floating menu before or after the content

Floating menu can cover the content of the document which can be a bit frustrating in my experience.

This is how Google does it: When you select a bullet list, some of the formatting options (text and highlight color) are hidden and new options to increase and decrease indent as well as a check list toggle are shown. We could do something similar with the increase and decrease indent buttons

No formatting Bullet list
image image

@flueders
Copy link
Author

Thank you for your reactions!

@nimishavijay @juliushaertl I also really like the idea of having a contextual toolbar. Nevertheless, I suggest considering the screen size for the toolbar's placement. On large screens, it perhaps would make sense to just add a second row below the top menu, whereas on smaller devices, the "split" between top menu and (contextual) bottom menu is more convenient.

@susnux
Copy link
Contributor

susnux commented May 31, 2022

The floating menu looks ok, but I fear it might get messy like the MenuBubble for links (bad UX).
The idea of hiding stuff might be nice and simple, as some features are useless when editing lists:

  • Bockquotes do not work
  • Callouts do not work
  • Codeblocks do not work

That are more than 2 buttons which would need to be replaced for the indention buttons :)

@max-nextcloud
Copy link
Collaborator

#2836 talks about the menu bar redesign. It will hopefully allow for adding these buttons.

@maximelehericy
Copy link

can confirm that decreasing the indent is impossible to do at the moment.... 😥

@max-nextcloud
Copy link
Collaborator

@maximelehericy

can confirm that decreasing the indent is impossible to do at the moment.... disappointed_relieved

Did you try shift+tab? - that just did the trick for me.
What type of list are you working on?

@susnux
Copy link
Contributor

susnux commented Aug 31, 2022

Did you try shift+tab? - that just did the trick for me. What type of list are you working on?

On mobile, where you do not have a shift key, there is indeed no way to change the indention level

@maximelehericy
Copy link

Did you try shift+tab? - that just did the trick for me.
What type of list are you working on?

Hmmm, now shift+tab works to decrease the indentation, but tab stopped working to increase it 😑🙂

@JKBWP
Copy link

JKBWP commented Nov 26, 2022

Hmmm, now shift+tab works to decrease the indentation, but tab stopped working to increase it 😑🙂

Same here, but it's a bit strange: in the Text app, the menu catches focus when pressing tab, so it's not possible to increase the indentation level. But in the Collectives app (which uses the Text app afaik), it works.

@Pilzinsel64
Copy link

Pilzinsel64 commented Nov 27, 2022

Hmmm, now shift+tab works to decrease the indentation, but tab stopped working to increase it 😑🙂

Same here, but it's a bit strange: in the Text app, the menu catches focus when pressing tab, so it's not possible to increase the indentation level. But in the Collectives app (which uses the Text app afaik), it works.

Oh yes, this is very strange. This can't be excpected, especially because Shift+Tag still works.
Want to mentoin that before nc25.0.2 get released. Hope the ping is ok. @juliushaertl

EDIT: #3493

@Pilzinsel64
Copy link

@JKBWP @maximelehericy
This comment might help you: #3493 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

10 participants