Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to set a guest name in public share #4252

Closed
mejo- opened this issue Jun 7, 2023 · 1 comment · Fixed by #5469
Closed

Not possible to set a guest name in public share #4252

mejo- opened this issue Jun 7, 2023 · 1 comment · Fixed by #5469

Comments

@mejo-
Copy link
Member

mejo- commented Jun 7, 2023

Describe the bug
In a publically shared document, we allow users to set a guest name during the session. This functionality is broken in Nextcloud 26 and 27.

From a first glance it looks like it didn't get migrated along with the recent syncService changes. @juliushaertl and @max-nextcloud since you have the most knowledge here, could you take a look?

To Reproduce
Steps to reproduce the behavior:

  1. Create a public share link for a document (with editing permissions)
  2. Open the public share link in a private tab, open the active users list
  3. Try to set a name for your session user
  4. See the error this.$syncService.session is undefined
  5. If you mitigate this error, next one is this.$syncService.updateSession(...) is undefined
@siccovansas
Copy link

This bug still exists in Hub 6/Nextcloud 27.1.2

mejo- added a commit that referenced this issue Mar 12, 2024
Fixes: #4252

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Mar 12, 2024
Fixes: #4252

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Mar 13, 2024
Fixes: #4252

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Mar 13, 2024
Fixes: #4252

Signed-off-by: Jonas <jonas@freesources.org>
backportbot bot pushed a commit that referenced this issue Mar 13, 2024
Fixes: #4252

Signed-off-by: Jonas <jonas@freesources.org>
backportbot bot pushed a commit that referenced this issue Mar 13, 2024
Fixes: #4252

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Mar 13, 2024
Fixes: #4252

Signed-off-by: Jonas <jonas@freesources.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants