Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening a read only share locks the file #5862

Closed
max-nextcloud opened this issue Jun 6, 2024 · 2 comments
Closed

Opening a read only share locks the file #5862

max-nextcloud opened this issue Jun 6, 2024 · 2 comments
Assignees
@max-nextcloud
Labels
28 feedback bug Something isn't working

Comments

@max-nextcloud
Copy link
Collaborator

Describe the bug
When opening a document read only

  • a session is created on the server
  • the document is locked
  • initial steps are pushed from the client but rejected by the server

To Reproduce
Steps to reproduce the behavior:

  1. Create a markdown file and share it read only
  2. Open the read only share without opening the file itself
  3. Check the lock and open the file for editing in another tab.
  4. See lock and failing initial load.

Expected behavior
Read only views should not lock the document or mess up the session state.

Screenshots
will attach later
@max-nextcloud max-nextcloud added the bug Something isn't working label Jun 6, 2024
@max-nextcloud
Copy link
Collaborator Author

#5597 would be the proper solution i guess.

@max-nextcloud max-nextcloud self-assigned this Jun 6, 2024
max-nextcloud added a commit that referenced this issue Jun 6, 2024
@max-nextcloud
fix(locks): only lock when editing
a85af74 
Read only shares should not lock a document.

Prevent file sync conflicts when nobody is editing.

See #5862.

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud max-nextcloud mentioned this issue Jun 6, 2024
Merged
4 tasks
@max-nextcloud max-nextcloud changed the title Opening a read only document creates a session and locks the file Opening a read only share locks the file Jun 6, 2024
backportbot bot pushed a commit that referenced this issue Jun 7, 2024
@max-nextcloud @backportbot
fix(locks): only lock when editing
68d26cc 
Read only shares should not lock a document.

Prevent file sync conflicts when nobody is editing.

See #5862.

Signed-off-by: Max <max@nextcloud.com>
backportbot bot pushed a commit that referenced this issue Jun 7, 2024
@max-nextcloud @backportbot
fix(locks): only lock when editing
17b12d3 
Read only shares should not lock a document.

Prevent file sync conflicts when nobody is editing.

See #5862.

Signed-off-by: Max <max@nextcloud.com>
backportbot bot pushed a commit that referenced this issue Jun 7, 2024
@max-nextcloud @backportbot
fix(locks): only lock when editing
5bd871c 
Read only shares should not lock a document.

Prevent file sync conflicts when nobody is editing.

See #5862.

Signed-off-by: Max <max@nextcloud.com>
@juliushaertl
Copy link
Member

Fixed by #5863

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@max-nextcloud max-nextcloud

Labels
28 feedback bug Something isn't working
Projects
📝 Office team
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@juliushaertl @max-nextcloud