Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yet another IE11 fixing round #1032

Merged
merged 4 commits into from
Sep 9, 2020
Merged

Yet another IE11 fixing round #1032

merged 4 commits into from
Sep 9, 2020

Conversation

juliushaertl
Copy link
Member

Fixes various issues with IE11:

  • Since some time IE11 was broken due to dependencies not being compatible anymore. Therefore I decided to for now just let all dependencies pass babel as I'm way to lazy to investigate which depedencies are culprit for an almost dead browser here and the build time is still ok
  • Multiple styling issues because IE doesn't support sticky positioning and does weird things in general

@juliushaertl
Just transpile all with babel
a48b479 
Otherwise we need to keep up with each dependency if it is actually IE11 compatible

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl
Use core-js and babel plugins
12d7c9a 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl
Fix IE styling bugs in rich workspaces and the editor
638524d 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl
Bump bundles
f6699d7 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl added bug Something isn't working 3. to review labels Sep 9, 2020
@juliushaertl juliushaertl added this to the Nextcloud 20 milestone Sep 9, 2020
@juliushaertl
Copy link
Member Author

/backport to stable19

@juliushaertl
Copy link
Member Author

/backport to stable18

@skjnldsv
Copy link
Member

skjnldsv commented Sep 9, 2020

Eager to reach nc22? :D

skjnldsv
skjnldsv approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No runtime-generator?
Not needed without the babel/polyfill ?

Didn't try but code looks good!

@juliushaertl
Copy link
Member Author

No runtime-generator

I couldn't see any issue with that, so let's get this in for now.

@juliushaertl juliushaertl merged commit 17d90a1 into master Sep 9, 2020
@juliushaertl juliushaertl deleted the bugfix/noid/ie11 branch September 9, 2020 09:26
@backportbot-nextcloud
Copy link

The backport to stable19 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable18 failed. Please do this backport manually.

@rullzer rullzer mentioned this pull request Sep 9, 2020
Merged
13 tasks
This was referenced Sep 11, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@julien-nc julien-nc Awaiting requested review from julien-nc

Assignees
No one assigned
Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
Nextcloud 20
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@juliushaertl @skjnldsv @ChristophWurst @MorrisJobke