Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify save indicator #1353

Merged
merged 7 commits into from
Feb 2, 2021
Merged

Simplify save indicator #1353

merged 7 commits into from
Feb 2, 2021

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Jan 14, 2021

Some fixes from the design review in #1075

Based on #1296

  • Simplify save indicator to Saving/Saved
  • Add some space to the menu bar so that button circles do no longer look cut off
  • Add disabled styling for undo/redo buttons Needed to revert this since it had a major performance impact and requires more investigation
  • Add improved indicator for active styling
  • Show full menubar on public share links (where the talk sidebar overlapped before)
  • Simplify wording
  • Add spacing to color annotations

Base automatically changed from enh/colors to master January 14, 2021 17:43
@juliushaertl juliushaertl marked this pull request as ready for review January 26, 2021 07:54
@juliushaertl juliushaertl added this to the Nextcloud 21 milestone Jan 26, 2021
@juliushaertl juliushaertl force-pushed the bugfix/1075/design branch 3 times, most recently from b8d757e to f6ac88d Compare January 26, 2021 15:53
This was referenced Jan 27, 2021
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
…ppening

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
…es or not

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl
Copy link
Member Author

cypress: default-group — 1 test failed

Failure from a previous run, but cypress doesn't update the state if the github action is just retriggered.

@rullzer
Copy link
Member

rullzer commented Feb 2, 2021

For me it shows all the way to the left. Is that intented?

2021-02-02_14-38

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as adverstied on regular md files.

@juliushaertl juliushaertl merged commit 38e37b2 into master Feb 2, 2021
@juliushaertl juliushaertl deleted the bugfix/1075/design branch February 2, 2021 14:39
@juliushaertl
Copy link
Member Author

Fix for that is in #1409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants