Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only register trailing node for rich text editing #1916

Merged
merged 1 commit into from
Oct 31, 2021

Conversation

juliushaertl
Copy link
Member

Follow up to #1771, otherwise loading plain text files will fail hard

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm bit didn't test

@szaimen
Copy link
Contributor

szaimen commented Oct 31, 2021

/compile amend /

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@szaimen szaimen force-pushed the bugfix/noid/trailing-node-syntax branch from 9acb2fb to 5fa82e0 Compare October 31, 2021 14:51
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works 👍

tested both, txt and md files with

click to expand
docker run -it \
-e VIEWER_BRANCH=master \
-e TEXT_BRANCH=bugfix/noid/trailing-node-syntax \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.146.130 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen merged commit 3abef38 into master Oct 31, 2021
@delete-merged-branch delete-merged-branch bot deleted the bugfix/noid/trailing-node-syntax branch October 31, 2021 14:57
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2021
19 tasks
@blizzz blizzz mentioned this pull request Nov 3, 2021
18 tasks
@azul azul added the backported successfully backported label Jan 11, 2022
@max-nextcloud max-nextcloud removed the backported successfully backported label Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants