Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable22] Use file.path to track more accurately EditorWrapper instances #2151

Merged
merged 1 commit into from Feb 17, 2022
Merged

[stable22] Use file.path to track more accurately EditorWrapper instances #2151

merged 1 commit into from Feb 17, 2022

Conversation

julien-nc
Copy link
Member

Backport of #2145

@julien-nc julien-nc added bug Something isn't working 3. to review labels Feb 3, 2022
@julien-nc julien-nc added this to the Nextcloud 22.2.5 milestone Feb 3, 2022
@julien-nc
Copy link
Member Author

/compile amend

@julien-nc julien-nc changed the title Use file.path to track more accurately EditorWrapper instances [stable22] Use file.path to track more accurately EditorWrapper instances Feb 3, 2022
@nextcloud-command
Use file.path to track more accurately EditorWrapper instances
5957435 
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the fix/stable22/rich_workspace_when_deplacing_readme branch from 026a13a to 5957435 Compare February 3, 2022 14:21
@blizzz blizzz mentioned this pull request Feb 11, 2022
Merged
12 tasks
max-nextcloud
max-nextcloud previously requested changes Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking since this may have unintended consequences.

Say i edit a file and you rename it in the meantime... What should happen? I think it's a feature and not a bug, that the editing keeps working and i now edit the file with the new name.

@max-nextcloud max-nextcloud dismissed their stale review February 17, 2022 04:54

tried it and now it works better than before.

@max-nextcloud max-nextcloud merged commit e4abdbd into stable22 Feb 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/stable22/rich_workspace_when_deplacing_readme branch February 17, 2022 04:54
@blizzz blizzz mentioned this pull request Mar 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejo- mejo- mejo- approved these changes

@artonge artonge artonge approved these changes

@max-nextcloud max-nextcloud max-nextcloud left review comments

Assignees
No one assigned
Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
Nextcloud 22.2.6
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@julien-nc @mejo- @artonge @max-nextcloud @blizzz