Fix broken file links #2268
Merged
Fix broken file links #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/compile amend |
nextcloud-command
force-pushed
the
fix/file-link
branch
from
1d1a0a3
to
11500b6
Compare
vinicius73
reviewed
Apr 5, 2022
|
/compile amend |
Signed-off-by: Julien Veyssier <eneiluj@posteo.net> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
fix/file-link
branch
from
7c2adbc
to
865cd8b
Compare
vinicius73
approved these changes
Apr 6, 2022
juliushaertl
approved these changes
Apr 6, 2022
This was referenced Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when opening Text from the files app and clicking a file link (created with the menu bubble), the target URL is
/apps/files/RELATIVE_PATH?fileId=FILE_IDwhich does not lead anywhere so we get redirected to the default app.This simple fix checks if the link points to NC and contains the
fileIDGET param. If so, an internal link is generated and opened.We could also change what's written in the file's content. Currently it's something like
[LINK_TEXT](RELATIVE_PATH?fileId=FILE_ID)Any thoughts on that?