Fix/eslint warning #2709
Merged
Fix/eslint warning #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-nextcloud
requested review from
a team,
Raudius and
juliushaertl
and removed request for
a team and
Raudius
mejo-
approved these changes
Jul 12, 2022
juliushaertl
approved these changes
Jul 12, 2022
juliushaertl
force-pushed
the
fix/eslint-warning
branch
from
681dd68
to
34f1f75
Compare
|
/rebase |
Signed-off-by: Max <max@nextcloud.com>
We do not have any warnings right now. Let us keep it that way. Signed-off-by: Max <max@nextcloud.com>
nextcloud-command
force-pushed
the
fix/eslint-warning
branch
from
34f1f75
to
9717567
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a license warning.
Also make the ci fail on npm lint warnings. We do not have any warnings right now. Let's make sure they do not sneak in by accident.