Fix typo in serializePlainText
#2730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the console output as everytime a txt file is loaded a exception is printed out that no matching language mapping is found for txt. Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
An empty text file should be serialized as `''` so fix checking if the document only contains an empty code block which type is `codeBlock` on tiptap v2 not `code_block`. Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
vinicius73
approved these changes
Jul 19, 2022
|
/compile |
|
/backport to stable24 |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
|
The backport to stable24 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
txtto plaintext mapping to prevent the console to be spammed with missing mapping messages when opening a bunch oftxtfiles.serializePlainTextas the TipTap v2 type name of a code block iscodeBlocknotcode_block, this prevents issues with empty non-markdown files.Ref.: https://github.com/ueberdosis/tiptap/blob/main/docs/overview/upgrade-guide.md#new-names-for-most-extensions