Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for @user mentions to RichTextReader.vue #2970

Merged
merged 3 commits into from Sep 20, 2022
Merged

Add support for @user mentions to RichTextReader.vue #2970

merged 3 commits into from Sep 20, 2022

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Sep 20, 2022

Summary

@mejo- mejo- added this to the Nextcloud 25 milestone Sep 20, 2022
max-nextcloud
max-nextcloud approved these changes Sep 20, 2022
View reviewed changes
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it myself. Codewise looks good.

Good catch that the config needs to be different in edit and readonly mode.

@blizzz blizzz mentioned this pull request Sep 20, 2022
Closed
@mejo-
Load Mention extension in RichText.js
679856a 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
Load Nextcloud server css files remotely from Github in index.html
ddcb3b3 
Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
Copy link
Member Author

mejo- commented Sep 20, 2022

/compile

@mejo- mejo- marked this pull request as ready for review September 20, 2022 16:17
@mejo- mejo- mentioned this pull request Sep 20, 2022
Closed
5 tasks
@nextcloud-command
Compile assets
99d8988 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@mejo- mejo- merged commit 019272e into master Sep 20, 2022
@delete-merged-branch delete-merged-branch bot deleted the enh/richtextreader branch September 20, 2022 16:26
@blizzz blizzz mentioned this pull request Sep 22, 2022
Merged
2 tasks
@vinicius73 vinicius73 mentioned this pull request Sep 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.

Add new features to RichTextReader
3 participants
@mejo- @max-nextcloud @nextcloud-command