fix: only save if needed when closing #3644
Conversation
Including tests that open and close do not save unedited files. Test is currently still failing for open. See #3543. Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
fix/3543-no-changes-no-save
branch
from
2ac410e
to
b695c8a
Compare
|
/compile |
|
/backport b695c8a to stable25 |
|
/backport b695c8a to stable24 |
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||
|
Okay... turns out a stable sync between client and server can take even longer than 4 roundtrips because the server only saves the doc every so and so often if it's an autosave and the first save was already triggered by the transaction caused by the headings. |
|
This PR misses the point. The server will only persist changes if the version has been bumped. So that should in itself already prevent saving without changes. |
Including tests that open and close do not save unedited files. Test is currently still failing for open.
See #3543.
npm run lint/npm run stylelint/composer run cs:check)