New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link picker #3700
Link picker #3700
Conversation
Awesome! I pushed a commit adding the glue to use the link picker in your suggestion plugin. Text needs to be linked with Remaining issues:
|
6db89bf
to
61ab927
Compare
@julien-nc Pushed a few very minor fixes for the issues you found. The focus trap issue I could not reproduce so I assume it is a side effect of another app that you have enabled on your setup. |
@juliushaertl Nice!
Are you ok with those changes? |
After frantically updating |
"Open link picker" action is there. The icon might not be the best one. |
ecffeda
to
2517b7c
Compare
Signed-off-by: Julius H盲rtl <jus@bitgrid.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julius H盲rtl <jus@bitgrid.net>
Signed-off-by: Julius H盲rtl <jus@bitgrid.net>
Signed-off-by: Julius H盲rtl <jus@bitgrid.net>
Signed-off-by: Julius H盲rtl <jus@bitgrid.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Julius H盲rtl <jus@bitgrid.net>
2517b7c
to
932a2dc
Compare
Ready for review and good to get in from my side 馃憤 Let's file follow up tickets for:
|
Very nice and works well 鉂わ笍 Unfortunately it brings back a bug that I had fixed in 6eb324f before: when opening the emoji picker, closing it with Esc and hitting enter, the emoji that was selected last still gets inserted. That's particularly annoying in languages like french, where single colons are often written. The same bug exists with mentions ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. The Text operating system is on its way.
Can confirm the bug mentioned by @mejo- for all users, emojis and link providers.
Signed-off-by: Julius H盲rtl <jus@bitgrid.net>
Pushed a fix that applies for all autocomplete components now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Works great and the latest fix by @juliushaertl also works 鉂わ笍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃憤
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Julius H盲rtl jus@bitgrid.net
馃摑 Summary
Depends on
馃弫 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)