[stable26] feat: update image view width and add title #4165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
backportbot-nextcloud
bot
requested review from
juliushaertl,
luka-nextcloud and
max-nextcloud
|
@luka-nextcloud Please double check if the backport is missing any code change outside of the generated js bundles. |
2 flaky tests on run #10085 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Open test.md in viewer > Share a file with download disabled shows an error |
Output
Screenshots
|
|
conflict.spec.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Open test.md in viewer > resolves conflict using server version |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
@juliushaertl It's not missing any code. Let me see why the cypress test is failing. |
luka-nextcloud
force-pushed
the
backport/4070/stable26
branch
from
8a76417
to
01f0330
Compare
|
appears to be in dev, moving to 26.0.3 |
juliushaertl
force-pushed
the
backport/4070/stable26
branch
from
01f0330
to
b7c8718
Compare
mejo-
force-pushed
the
backport/4070/stable26
branch
from
b7c8718
to
6987794
Compare
Signed-off-by: Luka Trovic <luka@nextcloud.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
mejo-
force-pushed
the
backport/4070/stable26
branch
from
6987794
to
7cd4acf
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
mejo-
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #4070