Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more deprecated API usages #4248

Merged
merged 2 commits into from Jun 7, 2023
Merged

No more deprecated API usages #4248

merged 2 commits into from Jun 7, 2023

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Jun 6, 2023

📝 Summary

  • chore: Move away from deprecated backend APIs
  • ci(paslm): Consider deprecated methods as errors

Since now all deprecated API usages are fixed I added the DeprecatedMethod as an error case to the psalm config as long as we cannot increase the psalm level (which might be a bit more work, but should be done)

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@juliushaertl juliushaertl requested review from blizzz and mejo- June 6, 2023 14:20
@juliushaertl juliushaertl changed the title chore/deprecations No more deprecated API usages Jun 6, 2023
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look sensible 👌

@cypress
Copy link

cypress bot commented Jun 6, 2023

1 flaky tests on run #10042 ↗︎

0 142 1 0 Flakiness 1

Details:

No more deprecated API usages
Project: Text Commit: 068fd19762
Status: Passed Duration: 03:30 💡
Started: Jun 7, 2023 8:32 PM Ended: Jun 7, 2023 8:36 PM
Flakiness  cypress/e2e/nodes/Mentions.spec.js • 1 flaky test

View Output Video

Test Artifacts
Test mentioning users > Type @ and see the user list Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl merged commit 2a23be8 into main Jun 7, 2023
41 checks passed
@juliushaertl juliushaertl deleted the chore/deprecations branch June 7, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants