Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable26] Don't expect HTML element with ID mimetype in public share #4257

Merged
merged 2 commits into from Jun 8, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Jun 7, 2023

  • ⚠️ This backport's changes differ from the original and might be incomplete

backport of #4253

@backportbot-nextcloud backportbot-nextcloud bot added the bug Something isn't working label Jun 7, 2023
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 26.0.3 milestone Jun 7, 2023
@mejo-
Copy link
Member

mejo- commented Jun 7, 2023

/compile

@cypress
Copy link

cypress bot commented Jun 7, 2023

6 failed and 32 flaky tests on run #10039 ↗︎

6 124 1 12 Flakiness 32

Details:

[stable26] Don't expect HTML element with ID `mimetype` in public share
Project: Text Commit: e347dd0a08
Status: Failed Duration: 17:18 💡
Started: Jun 7, 2023 8:10 PM Ended: Jun 7, 2023 8:27 PM
Failed  workspace.spec.js • 2 failed tests

View Output Video

Test Artifacts
Workspace > Hides the workspace when switching to another folder Output Screenshots
Workspace > takes README.md into account Output Screenshots
Failed  share.spec.js • 1 failed test

View Output Video

Test Artifacts
Open test.md in viewer > Shares the file as a public read only link Output Screenshots
Failed  nodes/Table.spec.js • 1 failed test

View Output Video

Test Artifacts
table plugin > Enter creates newline and navigates Output Screenshots
Failed  nodes/ImageView.spec.js • 1 failed test

View Output Video

Test Artifacts
Image View > direct access > from root Output Screenshots
Failed  conflict.spec.js • 1 failed test

View Output Video

Test Artifacts
Open test.md in viewer > resolves conflict using current editing session Output Screenshots
Flakiness  workspace.spec.js • 5 flaky tests

View Output Video

Test Artifacts
Workspace > adds a Readme.md Output Screenshots
Workspace > formats text Output Screenshots
Workspace > creates headings via submenu Output Screenshots
Workspace > relative folder links Output Screenshots
Workspace > callouts > create callout Output Screenshots
Flakiness  nodes/Links.spec.js • 3 flaky tests

View Output Video

Test Artifacts
test link marks > link preview > shows a link preview Output Screenshots
... > with selected text Output Screenshots
... > link to directory Output Screenshots
Flakiness  sync.spec.js • 3 flaky tests

View Output Video

Test Artifacts
Sync > saves on close Output Screenshots
Sync > recovers from a lost connection Output Screenshots
Sync > close triggers one close request Output Screenshots
Flakiness  shortcuts.spec.js • 3 flaky tests

View Output Video

Test Artifacts
keyboard shortcuts > ordered-list Output Screenshots
keyboard shortcuts > task-list Output Screenshots
keyboard shortcuts > heading-1 Output Screenshots
Flakiness  attachments.spec.js • 5 flaky tests

View Output Video

Test Artifacts
Test all attachment insertion methods > Insert an image file from Files Output Screenshots
Test all attachment insertion methods > test if attachment folder is moved with the markdown file Output Screenshots
Test all attachment insertion methods > test if attachment folder is copied when copying a markdown file Output Screenshots
Test all attachment insertion methods > [share] check everything behaves correctly on the share target user side Output Screenshots
Test all attachment insertion methods > Delete the user Output Screenshots

The first 5 flaky specs are shown, see all 14 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

mejo- and others added 2 commits June 8, 2023 08:18
If the share is password-protected, the authentication page doesn't have
the property set yet.

Fixes: #3816

Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@mejo- mejo- merged commit bc75a56 into stable26 Jun 8, 2023
32 checks passed
@delete-merged-branch delete-merged-branch bot deleted the backport/4253/stable26 branch June 8, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants