Make use of session middleware in remaining controllers

[juliushaertl]

Another larger backend changeset as a second part to #4266 to actually make use of it in the editing related controllers among a few cleanup tasks I did along the way.

Overall this should have some positive impact on performance as we reduce queries to fetch the session and document data to just one call in the middleware. Further way down in the the controller methods we just pass the objects around.

Let's see what cypress things about this.

• chore: Annotate controller methods in routes.php
• chore: Cleanup workspace controller
• chore: Refactor remaining controllers to make use of the session middleware
• chore: Cleanup in direct editing backend
• chore: Cleanup psalm baseline

📝 Summary

• Resolves: Refactor ApiService to fetch session once #3902

🏁 Checklist

• Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
• Sign-off message is added to all commits
• Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
• Documentation (README or documentation) has been updated or is not required

[cypress]

3 flaky tests on run #10476 ↗︎

0

147

1

0

3

Details:

Make use of session middleware in remaining controllers
Project: Text	Commit: 84dd2d3897
Status: Passed	Duration: 03:40 💡
Started: Jun 23, 2023 2:24 PM	Ended: Jun 23, 2023 2:28 PM

  sync.spec.js • 1 flaky test

View Output Video

Test		Artifacts
Sync > recovers from a lost connection		Output Screenshots

  nodes/Mentions.spec.js • 1 flaky test

View Output Video

Test		Artifacts
Test mentioning users > Type @ and see the user list		Output Screenshots

  api/UsersApi.spec.js • 1 flaky test

View Output Video

Test		Artifacts
The user mention API > fetches users with valid session		Output Screenshots

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[juliushaertl]

Need to check why the api test is flaky, could be either due to caching of the session or maybe the close request is not properly waited for

[mejo-]

/backport f5963e1 to stable27