Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link preview width on mobile #4327

Merged
merged 2 commits into from Jun 20, 2023

Conversation

luka-nextcloud
Copy link
Contributor

πŸ“ Summary

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
image

|
image

🚧 TODO

  • ...

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@cypress
Copy link

cypress bot commented Jun 20, 2023

1 flaky tests on run #10334 β†—οΈŽ

0 147 1 0 Flakiness 1

Details:

fix: link preview width on mobile
Project: Text Commit: c11f84ff3d
Status: Passed Duration: 03:17 πŸ’‘
Started: Jun 20, 2023 6:42 PM Ended: Jun 20, 2023 6:45 PM
FlakinessΒ  cypress/e2e/sync.spec.js β€’ 1 flaky test

View Output Video

Test Artifacts
Sync > recovers from a lost connection Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliushaertl juliushaertl added bug Something isn't working 4. to release labels Jun 20, 2023
@juliushaertl
Copy link
Member

/backport to stable27

@juliushaertl
Copy link
Member

/backport to stable26

Signed-off-by: Luka Trovic <luka@nextcloud.com>
@juliushaertl juliushaertl force-pushed the bugfix/link-preview-width-on-mobile branch from b7c6fed to f42d6e4 Compare June 20, 2023 18:36
@juliushaertl
Copy link
Member

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@juliushaertl juliushaertl merged commit cadbf81 into main Jun 20, 2023
33 checks passed
@juliushaertl juliushaertl deleted the bugfix/link-preview-width-on-mobile branch June 20, 2023 19:19
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@juliushaertl
Copy link
Member

/backport f42d6e4 to stable27

@juliushaertl
Copy link
Member

/backport f42d6e4 to stable26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detected link breaks mobile layout
3 participants