Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): Skip tiptap/prosemirror updates for 25 #4328

Merged
merged 1 commit into from Jun 21, 2023

Conversation

juliushaertl
Copy link
Member

As discussed with @max-nextcloud recently and to avoid reopening of #3752

@juliushaertl juliushaertl requested a review from mejo- June 20, 2023 20:11
@juliushaertl juliushaertl added dependencies Pull requests that update a dependency file 3. to review labels Jun 20, 2023
@cypress
Copy link

cypress bot commented Jun 20, 2023

1 failed and 2 flaky tests on run #10350 ↗︎

1 143 1 3 Flakiness 2

Details:

chore(dependencies): Skip tiptap/prosemirror updates for 25
Project: Text Commit: 3fe5572c65
Status: Failed Duration: 04:12 💡
Started: Jun 21, 2023 6:31 AM Ended: Jun 21, 2023 6:35 AM
Failed  cypress/e2e/nodes/FrontMatter.spec.js • 1 failed test

View Output Video

Test Artifacts
Front matter support > Open file with front matter Output Screenshots
Flakiness  sync.spec.js • 1 flaky test

View Output Video

Test Artifacts
Sync > recovers from a lost connection Output Screenshots
Flakiness  api/UsersApi.spec.js • 1 flaky test

View Output Video

Test Artifacts
The user mention API > fetches users with valid session Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

renovate.json Outdated
"enabled": false
},
{
"matchUpdateTypes": ["major"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this block twice?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, copy paste seems harder than expected 🙈 Fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehe, how about swapping the two blocks, so that the two tiptap blocks are one after each other? Sorry for the nitpicking, feel free to ignore 🤪

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that but wanted to rather group by stable branches from new to old ;)

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl merged commit 22db610 into main Jun 21, 2023
29 of 32 checks passed
@juliushaertl juliushaertl deleted the renovate/skip-tiptap-25 branch June 21, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants