fix: max width of editor container on mobile #4337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 failed and 2 flaky tests on run #10400 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Open test.md in viewer > See test.md in the list |
Output
Screenshots
|
|
sync.spec.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| Sync > recovers from a lost connection |
Output
Screenshots
|
|
api/UsersApi.spec.js • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| The user mention API > fetches users with valid session |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
juliushaertl
requested changes
Jun 21, 2023
| @@ -67,6 +67,12 @@ export default { | |||
| width: 100%; | |||
| } | |||
|
|
|||
| @media (max-width: 670px) { | |||
There was a problem hiding this comment.
It wasn't immediately obvious to me that this is the value of --text-editor-max-width.
Maybe we can just set a max-width in the above general .editor_content rule like this to keep it simple?
.editor__content {
max-width: min(var(--text-editor-max-width, calc(100vw - 16px));There was a problem hiding this comment.
Ok, please check again.
luka-nextcloud
force-pushed
the
bugfix/editor-max-width-on-mobile
branch
2 times, most recently
from
51e8da3
to
51fd070
Compare
luka-nextcloud
force-pushed
the
bugfix/editor-max-width-on-mobile
branch
from
51fd070
to
20fb69e
Compare
juliushaertl
approved these changes
Jun 22, 2023
Signed-off-by: Luka Trovic <luka@nextcloud.com>
juliushaertl
force-pushed
the
bugfix/editor-max-width-on-mobile
branch
from
20fb69e
to
8765b4f
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
|
/backport 8765b4f to stable27 |
|
/backport 8765b4f to stable26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)