Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide share and close buttons on direct editing for desktop #4346

Merged

Conversation

luka-nextcloud
Copy link
Contributor

πŸ“ Summary

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
image

|
image

🚧 TODO

  • ...

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@cypress
Copy link

cypress bot commented Jun 22, 2023

Passing run #10689 β†—οΈŽ

0 146 1 0 Flakiness 0

Details:

feat: hide share and close buttons on direct editing for desktop
Project: Text Commit: d0d9535719
Status: Passed Duration: 04:24 πŸ’‘
Started: Jun 27, 2023 7:12 AM Ended: Jun 27, 2023 7:17 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliushaertl juliushaertl force-pushed the feature/hide-share-and-close-buttons-on-direct-editing branch from 4bf2333 to ee7174a Compare June 23, 2023 07:25
@juliushaertl juliushaertl added bug Something isn't working 4. to release labels Jun 23, 2023
@juliushaertl juliushaertl added this to the Nextcloud 28 milestone Jun 23, 2023
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@juliushaertl juliushaertl force-pushed the feature/hide-share-and-close-buttons-on-direct-editing branch from ee7174a to 1764ea4 Compare June 27, 2023 06:47
@juliushaertl
Copy link
Member

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@juliushaertl juliushaertl merged commit 0defd4d into main Jun 27, 2023
33 checks passed
@juliushaertl juliushaertl deleted the feature/hide-share-and-close-buttons-on-direct-editing branch June 27, 2023 07:36
@juliushaertl
Copy link
Member

/backport to stable27

@juliushaertl
Copy link
Member

/backport to stable26

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@juliushaertl
Copy link
Member

@luka-nextcloud Can you take care of the manual backports?

@mejo-
Copy link
Member

mejo- commented Dec 6, 2023

/backport 1764ea4 to stable27

@juliushaertl
Copy link
Member

@luka-nextcloud Please have a look

@luka-nextcloud
Copy link
Contributor Author

luka-nextcloud commented Dec 7, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Desktop: Hide the close and share buttons in direct editing
4 participants