Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hotkey ctrl-s #4400

Merged
merged 2 commits into from Jun 28, 2023
Merged

fix: hotkey ctrl-s #4400

merged 2 commits into from Jun 28, 2023

Conversation

luka-nextcloud
Copy link
Contributor

πŸ“ Summary

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
B A

🚧 TODO

  • ...

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@luka-nextcloud luka-nextcloud added bug Something isn't working 3. to review labels Jun 27, 2023
@luka-nextcloud luka-nextcloud self-assigned this Jun 27, 2023
@cypress
Copy link

cypress bot commented Jun 27, 2023

Passing run #10752 β†—οΈŽ

0 146 1 0 Flakiness 0

Details:

fix: hotkey ctrl-s
Project: Text Commit: 20a1f83044
Status: Passed Duration: 07:16 πŸ’‘
Started: Jun 28, 2023 4:10 PM Ended: Jun 28, 2023 4:17 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm. Also fixes the same issue in Collectives.

Signed-off-by: Luka Trovic <luka@nextcloud.com>
@mejo-
Copy link
Member

mejo- commented Jun 28, 2023

/compile

@mejo-
Copy link
Member

mejo- commented Jun 28, 2023

/backport 111853b to stable27

@mejo-
Copy link
Member

mejo- commented Jun 28, 2023

/backport 111853b to stable26

@mejo-
Copy link
Member

mejo- commented Jun 28, 2023

/backport 111853b to stable25

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@mejo- mejo- merged commit b7008d9 into main Jun 28, 2023
31 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/hotkey-ctrl-s branch June 28, 2023 16:26
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

mejo- added a commit that referenced this pull request Jun 28, 2023
manual backport of #4400

Signed-off-by: Jonas <jonas@freesources.org>
@mejo-
Copy link
Member

mejo- commented Jun 28, 2023

Manual backport to stable25: #4419

@mejo-
Copy link
Member

mejo- commented Jun 28, 2023

@luka-nextcloud: I just saw that we still have old code in place that adds the "mod-s" shortcut to our keymap extension. This should be superfluous now. Could you please open a follow-up PR that removes it?

'Mod-s': () => {
this.$syncService.save()
return true
},

@mejo- mejo- mentioned this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl+S doesn't work
3 participants