Split sync of ApiService to sync and save

[blizzz]

📝 Summary

As discussed with @juliushaertl when talking about #3899 it might be worthwhile to split the sync route into dedicated sync and save endpoints.

🚧 TODO

• probably have to adjust cypress
• take care of PublicSessionController

🏁 Checklist

• Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
• Sign-off message is added to all commits
• Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
• Documentation (README or documentation) has been updated or is not required

[cypress]

Passing run #11441 ↗︎

0

149

2

0

0

Details:

Split sync of ApiService to sync and save
Project: Text	Commit: 0dd749bbcf
Status: Passed	Duration: 04:17 💡
Started: Jul 31, 2023 9:24 PM	Ended: Jul 31, 2023 9:28 PM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[juliushaertl]

We may still want to trigger the autosave somehow regular. I think this is no longer the case as only sync is called in an interval. Might be something to check with @max-nextcloud next week on how to best achieve that.

[blizzz]

It's actually still being triggered regularly. At least yesterday it was 🙈

[blizzz]

And that's the 30s autosave:

text/src/services/SyncService.js

Line 88 in 0d088d6

this.autosave = debounce(this._autosave.bind(this), AUTOSAVE_INTERVAL)

[max-nextcloud]

Thanks a lot for tackling this!
I have only one small remark.
Just went over the code did not test locally or go through untouched code to see if further changes would be needed.

[blizzz]

squahsed and rebased

[blizzz]

The remaining cypress errors about conflicts are rooted that this information was not transported on /sync anymore. This is fixed now. It works locally, but Cypress is still not convinced.… will continue there.

The handler we have, reacts to this status only on polling! Saves would be ignored, you could see the failures only on the console (before and after the changes). With the polling itself it's not a big deal.

[blizzz]

The remaining issue with cypress conflicts tests was an accidentally inverted condition, so that the proper exception was not thrown.