Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Encode individual parts of the dav url as uri components #4488

Merged
merged 2 commits into from Jul 12, 2023
Merged

fix: Encode individual parts of the dav url as uri components #4488

merged 2 commits into from Jul 12, 2023

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Jul 11, 2023 •
edited

📝 Summary

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@juliushaertl juliushaertl added bug Something isn't working 3. to review labels Jul 11, 2023
@juliushaertl juliushaertl added this to the Nextcloud 28 milestone Jul 11, 2023
@cypress
Copy link

cypress bot commented Jul 11, 2023 •
edited

1 failed and 1 flaky tests on run #10997 ↗︎

1 147 2 0 Flakiness 1

Details:

fix: Encode individual parts of the dav url as uri components
Project: Text Commit: b2140b5be6
Status: Failed Duration: 03:52 💡
Started: Jul 12, 2023 8:35 AM Ended: Jul 12, 2023 8:39 AM
Failed  cypress/e2e/sync.spec.js • 1 failed test

View Output Video

Test Artifacts
Sync > recovers from a lost connection Output Screenshots
Flakiness  cypress/e2e/nodes/Mentions.spec.js • 1 flaky test

View Output Video

Test Artifacts
Test mentioning users > Type @ and see the user list Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

mejo-
mejo- approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, works like a charm 😊

@juliushaertl @mejo-
fix: Encode individual parts of the dav url as uri components
e5aa7e7 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@mejo-
Copy link
Member

mejo- commented Jul 12, 2023

/compile

@nextcloud-command
chore(assets): Recompile assets
b2140b5 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@mejo- mejo- merged commit 6e66858 into main Jul 12, 2023
29 of 32 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/4156 branch July 12, 2023 08:40
@mejo-
Copy link
Member

mejo- commented Jul 12, 2023

/backport e5aa7e7 to stable27

@mejo-
Copy link
Member

mejo- commented Jul 12, 2023

/backport e5aa7e7 to stable26

This was referenced Jul 12, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejo- mejo- mejo- approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

Assignees
No one assigned
Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

Image attachment not shown when title of markdown file contains '#'
3 participants
@juliushaertl @mejo- @nextcloud-command