Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicated save key action #4495

Merged
merged 2 commits into from Jul 12, 2023

Conversation

luka-nextcloud
Copy link
Contributor

πŸ“ Summary

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
B A

🚧 TODO

  • ...

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@cypress
Copy link

cypress bot commented Jul 12, 2023

1 failed and 2 flaky tests on run #10994 β†—οΈŽ

1 147 2 0 Flakiness 2

Details:

fix: remove duplicated save key action
Project: Text Commit: bdfdff7d2a
Status: Failed Duration: 03:48 πŸ’‘
Started: Jul 12, 2023 8:24 AM Ended: Jul 12, 2023 8:28 AM
FailedΒ  cypress/e2e/sync.spec.js β€’ 1 failed test

View Output Video

Test Artifacts
Sync > recovers from a lost connection Output Screenshots
FlakinessΒ  nodes/Mentions.spec.js β€’ 1 flaky test

View Output Video

Test Artifacts
Test mentioning users > Type @ and see the user list Output Screenshots
FlakinessΒ  files.spec.js β€’ 1 flaky test

View Output Video

Test Artifacts
Text and server mimetypes > handle plaintext in a pre tag Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, works like expected 😊

@luka-nextcloud could you take care of backporting this to stable27, stable26 and stable25?

Signed-off-by: Luka Trovic <luka@nextcloud.com>
@mejo- mejo- force-pushed the bugfix/remove-duplicated-save-key-action branch from 4792589 to e187a7c Compare July 12, 2023 08:17
@mejo-
Copy link
Member

mejo- commented Jul 12, 2023

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@mejo- mejo- merged commit 7775c6b into main Jul 12, 2023
29 of 32 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/remove-duplicated-save-key-action branch July 12, 2023 08:28
@mejo-
Copy link
Member

mejo- commented Jul 13, 2023

/backport e187a7c to stable27

@mejo-
Copy link
Member

mejo- commented Jul 13, 2023

/backport e187a7c to stable26

@mejo-
Copy link
Member

mejo- commented Jul 13, 2023

/backport e187a7c to stable25

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl-S saves twice
3 participants