Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some JS deprecations #4496

Merged
merged 3 commits into from Jul 13, 2023
Merged

Fix some JS deprecations #4496

merged 3 commits into from Jul 13, 2023

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Jul 12, 2023

📝 Summary

  • Use OC.appswebroots instead of oc_appswebroots
  • Set aria-label for status button

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation is not required

@mejo- mejo- added this to the Nextcloud 28 milestone Jul 12, 2023
@cypress
Copy link

cypress bot commented Jul 12, 2023

1 flaky tests on run #11084 ↗︎

0 149 2 0 Flakiness 1

Details:

Fix some JS deprecations
Project: Text Commit: 2c6936f5c3
Status: Passed Duration: 03:46 💡
Started: Jul 13, 2023 9:21 AM Ended: Jul 13, 2023 9:25 AM
Flakiness  cypress/e2e/shortcuts.spec.js • 1 flaky test

View Output Video

Test Artifacts
keyboard shortcuts > ordered-list Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
@juliushaertl
Copy link
Member

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@juliushaertl juliushaertl merged commit ca41663 into main Jul 13, 2023
31 checks passed
@juliushaertl juliushaertl deleted the fix/js_deprecations branch July 13, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants