Fix save on direct editing #4510

juliushaertl · 2023-07-12T23:10:34Z

Re-add test assertions for closing the direct editing view and save (regression from 1764ea4)
Fix saving in direct editing after fix(sync): only save on close if changes were made #4503 which was only catched on stable branches due to the missing steps in the tests

I manually cherry-picked the second commit to #4509 and #4508

cypress · 2023-07-12T23:22:53Z

Passing run #11340 ↗︎

0	149	2	0	0

Details:

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}

Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliushaertl · 2023-07-27T18:57:27Z

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

juliushaertl added bug Something isn't working 3. to review regression labels Jul 12, 2023

juliushaertl force-pushed the fix/direct-editing-save branch from 98125c4 to 258ab64 Compare July 12, 2023 23:15

juliushaertl requested review from max-nextcloud, luka-nextcloud and mejo- July 12, 2023 23:20

juliushaertl force-pushed the fix/direct-editing-save branch 2 times, most recently from e42cb84 to e62a872 Compare July 13, 2023 07:40

luka-nextcloud approved these changes Jul 19, 2023

View reviewed changes

juliushaertl force-pushed the fix/direct-editing-save branch 2 times, most recently from 16a986d to 3cf0bda Compare July 24, 2023 15:35

juliushaertl changed the title ~~fix/direct editing save~~ Fix saveon direct editing Jul 24, 2023

juliushaertl changed the title ~~Fix saveon direct editing~~ Fix save on direct editing Jul 24, 2023

juliushaertl added 2 commits July 27, 2023 20:57

tests(cypress): Bring back close/save assertion for direct editing tests

4cbcaab

Signed-off-by: Julius Härtl <jus@bitgrid.net>

fix: Destroy editor to properly handle close/save in direct editing

fb8c836

Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliushaertl force-pushed the fix/direct-editing-save branch from 3cf0bda to fb8c836 Compare July 27, 2023 18:57

chore(assets): Recompile assets

0447b45

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

juliushaertl merged commit 6d2ee51 into main Jul 27, 2023
32 checks passed

juliushaertl deleted the fix/direct-editing-save branch July 27, 2023 19:18