Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable26] fix: Add index to session_id on text_steps table #4524

Merged
merged 3 commits into from Jul 17, 2023
Merged

[stable26] fix: Add index to session_id on text_steps table #4524

merged 3 commits into from Jul 17, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #4521

@backportbot-nextcloud backportbot-nextcloud bot added bug Something isn't working high labels Jul 14, 2023
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 26.0.4 milestone Jul 14, 2023
@cypress
Copy link

cypress bot commented Jul 14, 2023 •
edited

1 failed tests on run #11141 ↗︎

1 147 2 0 Flakiness 0

Details:

[stable26] fix: Add index to session_id on text_steps table
Project: Text Commit: 0cc479bb3e
Status: Failed Duration: 08:58 💡
Started: Jul 17, 2023 10:21 AM Ended: Jul 17, 2023 10:30 AM
Failed  cypress/e2e/share.spec.js • 1 failed test

View Output Video

Test Artifacts
Open test.md in viewer > Share a file with download disabled shows an error Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliushaertl
fix: Add index to session_id on text_steps table
a8b3385 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl
fix: Use prefilter for delete with subquery
cdb9990 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl
chore(deps): Update nextcloud/ocp
0cc479b 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@blizzz blizzz mentioned this pull request Jul 17, 2023
Merged
1 task
@blizzz
Copy link
Member

blizzz commented Jul 17, 2023

is cypress's failing test a flaky one or real?

@juliushaertl
Copy link
Member

This is a known one failing on random tests from time to time:

Screenshot 2023-07-17 at 13 09 19

@juliushaertl juliushaertl merged commit 304369e into stable26 Jul 17, 2023
37 of 41 checks passed
@delete-merged-branch delete-merged-branch bot deleted the backport/4521/stable26 branch July 17, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@mejo- mejo- mejo- approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees
No one assigned
Labels
4. to release bug Something isn't working high
Projects
None yet
Milestone
Nextcloud 26.0.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@blizzz @juliushaertl @nickvergessen @mejo-