Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(postgres): Use a unique index name #4553

Merged
merged 1 commit into from Jul 20, 2023

Conversation

nickvergessen
Copy link
Member

ts_session is already used in Talk since Nextcloud 22. Unluckily in Postgres index names have to be unique inside the database, not only per table.

📝 Summary

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

ts_session is already used in Talk since Nextcloud 22.
Unluckily in Postgres index names have to be unique inside the database,
not only per table.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@cypress
Copy link

cypress bot commented Jul 19, 2023

1 flaky tests on run #11180 ↗︎

0 149 2 0 Flakiness 1

Details:

fix(postgres): Use a unique index name
Project: Text Commit: 0f2520c357
Status: Passed Duration: 03:38 💡
Started: Jul 19, 2023 10:35 PM Ended: Jul 19, 2023 10:39 PM
Flakiness  cypress/e2e/attachments.spec.js • 1 flaky test

View Output Video

Test Artifacts
Test all attachment insertion methods > [share] check everything behaves correctly on the share target user side Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliushaertl juliushaertl merged commit 08a9a05 into main Jul 20, 2023
35 checks passed
@juliushaertl juliushaertl deleted the bugfix/noid/unique-index-name branch July 20, 2023 05:35
@juliushaertl
Copy link
Member

/backport to stable27

@juliushaertl
Copy link
Member

/backport to stable26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants