Stricter typing to match psalm level 2 #4584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliushaertl
force-pushed
the
chore/stricter
branch
from
2537d6c
to
e908731
Compare
Passing run #11337 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
juliushaertl
force-pushed
the
chore/stricter
branch
2 times, most recently
from
9fe178a
to
1b300ce
Compare
juliushaertl
requested review from
mejo- and
max-nextcloud
and removed request for
mejo-
mejo-
approved these changes
Jul 25, 2023
| @@ -77,6 +77,7 @@ private function detectUtfBom(string $string): ?string { | |||
| */ | |||
| private function getEncodings(): array { | |||
| $mbOrder = mb_detect_order() ?: []; | |||
There was a problem hiding this comment.
The return value is still needed, unfortunately the return value of mb_detect_order is strange as it is documented to return a bool|array while when calling it without an argument it will always return an array. I've updated the relevant line to require the duplicate variable assignment
| @@ -127,6 +124,8 @@ public function create($fileId = null, $filePath = null, ?string $token = null, | |||
| return new DataResponse('Failed to create the document session', 500); | |||
| } | |||
|
|
|||
| /** @var Document $document */ | |||
|
|
|||
There was a problem hiding this comment.
Nitpicking, but this empty line is superfluous, no?
There was a problem hiding this comment.
This is not the var of the left line but an indicator for psalm not detecting that document is never undefined in this case (which seems like a false positive).
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
chore/stricter
branch
from
1b300ce
to
7b24775
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did some work towards higher psalm levels during todays travel, let's see what CI thinks about that