[stable27] Text processing integration #4662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliushaertl
requested review from
luka-nextcloud and
max-nextcloud
and removed request for
luka-nextcloud
1 flaky tests on run #11631 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sync service provider > recovers from a dropped message |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
juliushaertl
force-pushed
the
backport/4627/stable27
branch
from
26b2bf3
to
524c0a0
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
backport/4627/stable27
branch
from
524c0a0
to
6497bd0
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
AndyScherzinger
approved these changes
Aug 10, 2023
juliushaertl
commented
Aug 12, 2023
| getReferenceClientRect: () => { | ||
| const editorRect = this.$parent.$el.querySelector('.ProseMirror').getBoundingClientRect() | ||
| const pos = posToDOMRect(this.$editor.view, this.$editor.state.selection.from, this.$editor.state.selection.to) | ||
| return { |
There was a problem hiding this comment.
Just leaving this here in case relevant for future debugging. Adding a div to position above the editor for fiddling with the positioning has been quite helpful:
// Add template
<div class="floating-hover" />
// Add styles
.floating-hover {
background-color: rgba(255,0,0,0.4);
position: fixed;
top:0;
left: 0;
width: 100px;
height: 100px;
}
// Add here
document.querySelector('.floating-hover').style.width = rect.width + 'px'
document.querySelector('.floating-hover').style.height = rect.height + 'px'
document.querySelector('.floating-hover').style.top = rect.top + 'px'
document.querySelector('.floating-hover').style.left = rect.left + 'px'
document.querySelector('.floating-hover').style.bottom = rect.bottom + 'px'
document.querySelector('.floating-hover').style.right = rect.right + 'px'
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4627