Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hide workspace if no readme.md #4771

Merged
merged 1 commit into from Sep 6, 2023

Conversation

luka-nextcloud
Copy link
Contributor

πŸ“ Summary

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
B A

🚧 TODO

  • ...

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@cypress
Copy link

cypress bot commented Sep 5, 2023

3 failed and 2 flaky tests on run #12040 β†—οΈŽ

3 141 18 0 Flakiness 2

Details:

feat: hide workspace if no readme.md
Project: Text Commit: 6ed2d08e39
Status: Failed Duration: 05:15 πŸ’‘
Started: Sep 6, 2023 6:53 AM Ended: Sep 6, 2023 6:58 AM
FailedΒ  cypress/e2e/attachments.spec.js β€’ 3 failed tests

View Output Video

Test Artifacts
Test all attachment insertion methods > test if attachment folder is moved with the markdown file Output Screenshots
Test all attachment insertion methods > test if attachment folder is copied when copying a markdown file Output Screenshots
Test all attachment insertion methods > [share] check everything behaves correctly on the share target user side Output Screenshots
FlakinessΒ  nodes/CodeBlock.spec.js β€’ 1 flaky test

View Output Video

Test Artifacts
Front matter support > Add a valid mermaid block Output Screenshots
FlakinessΒ  files.spec.js β€’ 1 flaky test

View Output Video

Test Artifacts
Text and server mimetypes > handle markdown with richtext editor Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Signed-off-by: Luka Trovic <luka@nextcloud.com>
@juliushaertl juliushaertl force-pushed the feature/hide-rich-workspace-if-no-readme branch from bfba068 to 6ed2d08 Compare September 6, 2023 06:45
@juliushaertl juliushaertl merged commit 0730362 into main Sep 6, 2023
29 of 32 checks passed
@juliushaertl juliushaertl deleted the feature/hide-rich-workspace-if-no-readme branch September 6, 2023 13:59
@mejo-
Copy link
Member

mejo- commented Sep 21, 2023

/backport to stable27

@mejo-
Copy link
Member

mejo- commented Sep 21, 2023

/backport to stable26

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide rich workspace header when there is no Readme.md
4 participants