Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move new file action to F2V api #4873

Merged
merged 3 commits into from Oct 30, 2023
Merged

Conversation

luka-nextcloud
Copy link
Contributor

@luka-nextcloud luka-nextcloud commented Oct 17, 2023

๐Ÿ“ Summary

๐Ÿ–ผ๏ธ Screenshots

๐Ÿš๏ธ Before ๐Ÿก After
image image

๐Ÿšง TODO

  • ...

๐Ÿ Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@luka-nextcloud luka-nextcloud self-assigned this Oct 17, 2023
@luka-nextcloud luka-nextcloud added tests If you write them we โ™ฅ you 3. to review labels Oct 17, 2023
@juliushaertl juliushaertl force-pushed the bugfix/workspace-cypress-test branch 2 times, most recently from fcd52aa to ed21022 Compare October 26, 2023 13:13
luka-nextcloud and others added 3 commits October 30, 2023 08:17
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Julius Hรคrtl <jus@bitgrid.net>
Signed-off-by: Julius Hรคrtl <jus@bitgrid.net>
@juliushaertl juliushaertl changed the title fix: workspace cypress tests fix: Move new file action to F2V api Oct 30, 2023
@juliushaertl
Copy link
Member

I pushed a fix for the jest tests and the check to show the entry

https://github.com/nextcloud/text/pull/4853/files#r1358150289 still needs to get addressed to have tests for the button itself creating a new file.

@juliushaertl juliushaertl merged commit 9933579 into main Oct 30, 2023
33 of 35 checks passed
@juliushaertl juliushaertl deleted the bugfix/workspace-cypress-test branch October 30, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review tests If you write them we โ™ฅ you
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bring back files menu item "Add description"
2 participants