Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mermaid): Only switch back on failure if in preview mode #4875

Merged
merged 1 commit into from Oct 25, 2023
Merged

fix(mermaid): Only switch back on failure if in preview mode #4875

merged 1 commit into from Oct 25, 2023

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Oct 18, 2023 •
edited

馃摑 Summary

馃弫 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@juliushaertl
fix(mermaid): Only switch back on failure if in preview mode
aca5099 
Signed-off-by: Julius H盲rtl <jus@bitgrid.net>
@juliushaertl juliushaertl added bug Something isn't working 3. to review labels Oct 19, 2023
@juliushaertl juliushaertl added this to the Nextcloud 28 milestone Oct 20, 2023
@juliushaertl
Copy link
Member Author

/backport to stable27

mejo-
mejo- approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible, thanks for tackling this!

@juliushaertl juliushaertl merged commit 8118778 into main Oct 25, 2023
29 of 31 checks passed
@juliushaertl juliushaertl deleted the bugfix/4815 branch October 25, 2023 11:29
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejo- mejo- mejo- approved these changes

@christianlupus christianlupus Awaiting requested review from christianlupus

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud

Assignees
No one assigned
Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

Mermaid jumps back to side-by-side mode
2 participants
@juliushaertl @mejo-