Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(readme): Clarify the dependency on the viewer app #4887

Merged
merged 1 commit into from Oct 20, 2023

Conversation

provokateurin
Copy link
Member

馃摑 Summary

When I setup this app it wasn't immediately clear what I had to do regarding the viewer app. I clarified it a bit which should help other people with the setup.

馃弫 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

Signed-off-by: jld3103 <jld3103yt@gmail.com>
@juliushaertl juliushaertl merged commit 3303831 into main Oct 20, 2023
20 checks passed
@juliushaertl juliushaertl deleted the fix/readme/clarify-viewer-app-dependency branch October 20, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants