Use `@nextcloud/dialogs` v5 (required for FilePicker on Nextcloud 28+) #4890

susnux · 2023-10-21T17:58:37Z

Otherwise the FilePicker looks quite odd.

🏚️ Before	🏡 After

Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
Sign-off message is added to all commits
Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
Documentation (README or documentation) has been updated or is not required

juliushaertl · 2023-10-23T07:26:06Z

Thanks a lot @susnux

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Signed-off-by: Julius Härtl <jus@bitgrid.net>

susnux added bug Something isn't working 3. to review dependencies: javascript labels Oct 21, 2023

susnux requested review from juliushaertl and max-nextcloud October 21, 2023 17:58

susnux force-pushed the fix/dialogs-v5 branch from 280fe99 to c63ded1 Compare October 21, 2023 18:00

susnux added this to the Nextcloud 28 milestone Oct 21, 2023

juliushaertl approved these changes Oct 23, 2023

View reviewed changes

juliushaertl force-pushed the fix/dialogs-v5 branch from c63ded1 to 32e1874 Compare October 23, 2023 07:25

juliushaertl added 4. to release and removed 3. to review labels Oct 23, 2023

mejo- force-pushed the fix/dialogs-v5 branch from 32e1874 to ea32489 Compare October 27, 2023 19:25

susnux and others added 2 commits October 29, 2023 19:27

fix: Move to @nextcloud/dialogs v5 for FilePicker

5ee2b5a

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

tests: mock @nextcloud/dialogs in jest

f697f34

Signed-off-by: Julius Härtl <jus@bitgrid.net>

juliushaertl force-pushed the fix/dialogs-v5 branch from ea32489 to f697f34 Compare October 29, 2023 18:27

juliushaertl merged commit fc60921 into main Oct 29, 2023
33 of 35 checks passed

juliushaertl deleted the fix/dialogs-v5 branch October 29, 2023 19:10

Provide feedback